add the h2c app protocol value for the HTTP2 test #936
Conversation
knative-prow
bot
added
approved
| @@ -558,7 +562,7 @@ func CreateGRPCService(ctx context.Context, t *testing.T, clients *test.Clients, | |||
| Name: networking.ServicePortNameH2C, | |||
| Port: int32(port), | |||
| TargetPort: intstr.FromInt(containerPort), | |||
| AppProtocol: ptr.String("kubernetes.io/h2c"), | |||
| AppProtocol: ptr.String(networking.AppProtocolH2C), | |||
There was a problem hiding this comment.
Realized there's a constant where this value is defined
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
==========================================
- Coverage 24.03% 24.00% -0.03%
==========================================
Files 91 91
Lines 5130 5136 +6
==========================================
Hits 1233 1233
- Misses 3884 3890 +6
Partials 13 13 ☔ View full report in Codecov by Sentry. |
|
/override "codecov/project" |
|
@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest /override "codecov/project" |
|
@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I missed setting the h2c appProtocol label for the HTTP2 test in #932
/assign @izabelacg